Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge build and host envs #49

Merged
merged 2 commits into from
May 16, 2020
Merged

Merge build and host envs #49

merged 2 commits into from
May 16, 2020

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 16, 2020 •
edited
Loading

This should fix the issue with prefix replacement.

closes #48

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xylar
Merge build and host envs
b1f14f1 
This should fix the issue with prefix replacement.
@xylar xylar requested review from beckermr, bekozi and ocefpaf as code owners May 16, 2020 11:38
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@xylar
Copy link
Contributor Author

xylar commented May 16, 2020

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented May 16, 2020

I tested this locally on my laptop and was able to get the expected path from nc-config --fc:

$ conda build -m .ci_support/linux_mpinompi.yaml recipe
$ conda create -n test --use-local netcdf-fortran
$ conda activate test
$ nc-config --fc
/home/xylar/miniconda3/envs/test/bin/x86_64-conda_cos6-linux-gnu-gfortran

@xylar
Copy link
Contributor Author

xylar commented May 16, 2020

@beckermr, thanks for your suggestion on this!

@xylar xylar mentioned this pull request May 16, 2020
Open
@xylar xylar added the automerge Merge the PR when CI passes label May 16, 2020
@github-actions github-actions bot merged commit 80f170e into conda-forge:master May 16, 2020
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@xylar xylar deleted the merge_host_build branch May 16, 2020 11:52
@beckermr
Copy link
Member

@xylar Can we add this as a test to the recipe?

@xylar
Copy link
Contributor Author

xylar commented May 16, 2020

Yep, I'm adding one in #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr Awaiting requested review from beckermr

@bekozi bekozi Awaiting requested review from bekozi

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong gfortran path from nc-config
3 participants
@xylar @conda-forge-linter @beckermr